Hello, On 9 January 2011 21:27, seedshope <bocui...@gmail.com> wrote: > On 01/09/2011 03:33 PM, Minkyu Kang wrote: >> >> Hi >> >> On 9 January 2011 10:14, seedshope<bocui...@gmail.com> wrote: >>> >>> On 01/08/2011 11:15 PM, Minkyu Kang wrote: >>>> >>>> Dear seedshope, >>>> >>>> On 8 January 2011 00:53, seedshope<bocui...@gmail.com> wrote: >>>>> >>>>> From: seedshope<bocui...@gmail.com> >>>>> >>>>> Modify u-boot.lds from nand_spl/board/samsung/smdk6400. >>>>> >>>>> start.o: In function `clbss_l': >>>>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>>>> `coloured_LED_init' >>>>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>>>> `red_LED_on' >>>>> start.o: In function `_rel_dyn_start_ofs': >>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>> `__rel_dyn_start' >>>>> start.o: In function `_rel_dyn_end_ofs': >>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>> `__rel_dyn_end' >>>>> start.o: In function `_dynsym_start_ofs': >>>>> nand_spl/board/samsung/smdk6400/start.S:366: undefined reference to >>>>> `__dynsym_start' >>>>> >>>>> Signed-off-by: seedshope<bocui...@googlemail.com> >>>>> >>>>> diff --git a/arch/arm/cpu/arm1176/start.S >>>>> b/arch/arm/cpu/arm1176/start.S >>>>> index 237dcfe..bde0357 100644 >>>>> --- a/arch/arm/cpu/arm1176/start.S >>>>> +++ b/arch/arm/cpu/arm1176/start.S >>>>> @@ -353,10 +353,11 @@ clbss_l:str r2, [r0] /* >>>>> clear >>>>> loop... */ >>>>> add r0, r0, #4 >>>>> cmp r0, r1 >>>>> bne clbss_l >>>>> - >>>>> +#ifndef CONFIG_NAND_SPL >>>> >>>> CONFIG_PRELOADER is better >>> >>> No, The nand_spl support can't find the define of coloured_LED_init and >>> red_LED_on. >>> It is base on the build error: >>> >>> make smdk6400_config >>> make >>> the error information as following: >>> >>> nand_spl/board/samsung/smdk6400/start.S:357: undefined reference to >>> `coloured_LED_init' >>> nand_spl/board/samsung/smdk6400/start.S:358: undefined reference to >>> `red_LED_on' >>> >> Please add follow define at Makefile. >> AFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL >> CFLAGS += -DCONFIG_PRELOADER -DCONFIG_NAND_SPL > > ok, It may be a good method. > > But I worried other people will be difficult to see the process of the code > running. > So, if add #ifdef CONFIG_NAND_SPL, It is very clear. What do you think > about it? >
Ah, already used CONFIG_NAND_SPL at start.S. OK, we can do this work (change from CONFIG_NAND_SPL to CONFIG_PRELOADER) at another patch. Thanks Minkyu Kang -- from. prom. www.promsoft.net _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
