Hi Heinrich,

On Mon, 17 Oct 2022 at 16:10, Heinrich Schuchardt <xypron.g...@gmx.de> wrote:
>
> On 10/17/22 22:29, Simon Glass wrote:
> > Split this functionality out of the 'source' command so it can be used
> > from another place.
>
> It is not obvious how this relates to changing the series.
>
> Please, provide a description of the future use of the extracted library
> function.
>
> >
> > Signed-off-by: Simon Glass <s...@chromium.org>
> > ---
> >
> >   cmd/source.c    | 173 ++++++++++++++++++++++++++----------------------
> >   include/image.h |  13 ++++
>
> If you extract a library function, it should not live in cmd/source.c.
>

I can put it in boot/image*.c perhaps.

Regards,
Simon

Reply via email to