Hi Stefan, On Mon, 22 Aug 2022 at 01:07, Stefan Herbrechtsmeier <stefan.herbrechtsmeier-...@weidmueller.com> wrote: > > Hi Simon, > > Am 21.08.2022 um 02:10 schrieb Simon Glass: > > Hi Stefan, > > > > On Sat, 20 Aug 2022 at 15:33, Simon Glass <s...@chromium.org> wrote: > >> > >> On Fri, 19 Aug 2022 at 08:26, Stefan Herbrechtsmeier > >> <stefan.herbrechtsmeier-...@weidmueller.com> wrote: > >>> > >>> From: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com> > >>> > >>> Add gzip bintool to binman to support on-the-fly compression of Linux > >>> kernel images and FPGA bitstreams. The SPL basic fitImage implementation > >>> supports only gzip decompression. > >>> > >>> Signed-off-by: Stefan Herbrechtsmeier > >>> <stefan.herbrechtsme...@weidmueller.com> > >>> > >>> --- > >>> > >>> (no changes since v5) > >>> > >>> Changes in v5: > >>> - Add algorithm name to entry.py > >>> - Add tool name to ftest.py > >>> > >>> Changes in v2: > >>> - Add commit to add gzip bintool > >>> > >>> tools/binman/btool/gzip.py | 31 +++++++++++++++++++++++++++++++ > >>> tools/binman/entry.py | 2 +- > >>> tools/binman/ftest.py | 2 +- > >>> 3 files changed, 33 insertions(+), 2 deletions(-) > >>> create mode 100644 tools/binman/btool/gzip.py > >>> > >> > >> Reviewed-by: Simon Glass <s...@chromium.org> > > > > Unfortunately this conflicts with the system gzip.py module so I have > > had to rework this a little. > > Should we use bz2, gzip and lzma modules instead of the bintools?
We could, but it is harder for people to replicate the behaviour in that case. Also some of those may not be installed. There is no actual ambiguity with the module names, except that pylint gets confused. I don't have strong opinions about this, but however it works needs to be easy for people to fetch tools. Regards, Simon
