hi Simon, On Thu, 18 Aug 2022 at 23:19, Simon Glass <s...@chromium.org> wrote: > > Hi Sughosh, > > On Thu, 18 Aug 2022 at 05:53, Sughosh Ganu <sughosh.g...@linaro.org> wrote: > > > > hi Simon, > > > > On Thu, 18 Aug 2022 at 08:51, Simon Glass <s...@chromium.org> wrote: > > > > > > Hi Sugosh, > > > > > > On Wed, 17 Aug 2022 at 06:44, Sughosh Ganu <sughosh.g...@linaro.org> > > > wrote: > > > > > > > > Add a command to read the metadata as specified in the FWU > > > > specification and print the fields of the metadata. > > > > > > > > Signed-off-by: Sughosh Ganu <sughosh.g...@linaro.org> > > > > Reviewed-by: Ilias Apalodimas <ilias.apalodi...@linaro.org> > > > > --- > > > > Changes since V7: None > > > > > > > > cmd/Kconfig | 7 +++++ > > > > cmd/Makefile | 1 + > > > > cmd/fwu_mdata.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++++ > > > > 3 files changed, 88 insertions(+) > > > > create mode 100644 cmd/fwu_mdata.c > > > > > > This needs docs and a test. > > > > > > BTW I forgot to mention that the uclass needs a simple test of some sort. > > > > > > https://u-boot.readthedocs.io/en/latest/develop/tests_writing.html > > > > Okay. I will check how this can be done. Btw, there are plans to add a > > test for the feature once support for the feature has been added on > > the Synquacer platform. That test will exercise the above command as > > well as the driver code. Do we still need a standalone test for the > > uclass? > > Yes, testing on real hardware has nothing to do with the uclass test, which > runs on sandbox. It should be a small unit test like others in test/dm/...
I am not talking about testing on real hardware, but a test to be run on sandbox. I had posted the relevant patch [1] in an earlier version of the patch series. But this test relies on support being added for the feature on the Synquacer platform. Once those patches get in, I will be adding the test for the feature as well. And this test exercises both the fwu_mdata_read command as well as the driver code. Which is why I was asking if it is necessary to add additional tests for the command and dm code. -sughosh [1] - https://lists.denx.de/pipermail/u-boot/2022-June/485992.html > > Regards, > Simon
