On 8/5/2022 6:33 PM, William Zhang wrote:
Broadcom BCA (Broadband Carrier Access origin) chipset family includes
DSL, PON and WLAN access point and gateway SoC. Now that the ARCH_BCMBCA
architecture and its first SoC BCM47622 are supported in u-boot 2022.07,
this patch series add the basic support for following BCA chips under
ARCH_BCMBCA: BCM4908, BCM4912, BCM63146 and BCM6813.

This patch series applies on top of the my previous patch [1].

[1] https://lists.denx.de/pipermail/u-boot/2022-August/491060.html

Looks good to me, thanks William! On the mmu_table.c implementation maybe just a few nits:

- should not we do an early parsing of the memory node for the given board(s) to ensure that we map no more than the amount of available DRAM?

- the exact same file is currently being re-used, so it would make sense to make it a common object

- you could create a memory mapping for the AXI bus region right away to avoid forgetting about it later if you start bringing up drivers that make use of that peripheral region

Thanks!
--
Florian

Reply via email to