Hi Simon, On Sun, Aug 07, 2022 at 09:47:56AM -0600, Simon Glass wrote: > Hi Marek, > > On Thu, 21 Jul 2022 at 11:29, Janne Grunau <j...@jannau.net> wrote: > > > > Fixes a crash during probing of sd card readers without medium present. > > > > Link: https://github.com/AsahiLinux/linux/issues/44 > > Signed-off-by: Janne Grunau <j...@jannau.net> > > --- > > common/usb_storage.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > Reviewed-by: Simon Glass <s...@chromium.org>
I made this comment on another bug report: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html I think we should continue to scan the *bus* even if detecting/activating a specific device fails. Moreover, we would better do full recovery from blk_create_device(f)() as it has some side-effects, including an increased "devnum". -Takahiro Akashi > Shall I pick this one up? > > Regards, > Simon