On Thu, Aug 4, 2022 at 5:44 AM Tom Rini <tr...@konsulko.com> wrote:
>
> On Wed, Aug 03, 2022 at 07:27:50PM +0200, Heinrich Schuchardt wrote:
> > On 8/3/22 18:26, Quentin Schulz wrote:
> > > Hi Tom,
> > >
> > > On 8/3/22 18:08, Tom Rini wrote:
> > > > On Wed, Aug 03, 2022 at 04:39:52PM +0200, Heinrich Schuchardt wrote:
> > > >
> > > > > Only five boards are left that need to be migrated to DM_GPIO. Set a
> > > > > 2023.04 deadline.
> > > > >
> > > > > * edminiv2_defconfig
> > > > > * mx28evk_auart_console_defconfig
> > > > > * mx28evk_nand_defconfig
> > > > > * mx28evk_spi_defconfig
> > > > > * warp_defconfig
> > > > >
> > > > > Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
> > > >
> > > > I see you've now ack'd Fabio's patch to remove those mx28 configs.
> > > > Here's my patch to remove edminiv2:
> > > > https://patchwork.ozlabs.org/project/uboot/patch/20220802113424.2988464-6-tr...@konsulko.com/
> > > >
> > > > That leaves just "warp", which is missing a ton of conversions, so let
> > > > me just post a removal patch instead and see where it goes.
> > > >
> > >
> > > I guess this would also mean the removal of GPIO drivers that haven't
> > > moved to DM?
> > >
> > > # git grep -L UCLASS drivers/gpio/*.c
> > > drivers/gpio/adi_gpio2.c
> > > drivers/gpio/kona_gpio.c
> > > drivers/gpio/kw_gpio.c
> > > drivers/gpio/mpc83xx_gpio.c
> > > drivers/gpio/mvgpio.c
> > > drivers/gpio/pca953x.c
> > > drivers/gpio/pca9698.c
> > > drivers/gpio/sh_pfc.c
> > > drivers/gpio/tca642x.c
> >
> > I tried to remove the drivers but that leads to errors in
> > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/13021
>
> I did a similar test, but on top of my DM_ETH branch so some platforms
> got removed already. The fatal platform list is:
> SBx81LIFKW lschlv2 lsxhl dns325 km_kirkwood km_kirkwood_128m16
> km_kirkwood_pci kmcoge5un kmnusa kmsuse2 d2net_v2 net2big_v2
> inetspace_v2 netspace_lite_v2 netspace_max_v2 netspace_mini_v2
> netspace_v2 omap5_uevm
>
> and I've cc'd the maintainers. Folks, are you able to pick up and
> convert the GPIO driver that your platform relies on to DM_GPIO soon, or
> should we just disable the GPIO driver? Or drop the platform? Thanks!
>
(sorry for the odd threading, failed reply-all+gmail so the content
below only went to Tom)
The current users of kw_gpio.c should be able to switch to
mvebu_gpio.c with some minor changes (the equivalent linux driver
supports the kirkwood Soc). I'll try and take a look and convert my
boards over. I could do a blind conversion of the other boards if
no-one with actual hardware pipes up.
I notice that mvgpio is on your list but I think the last user of
CONFIG_MARVELL_GPIO was removed in commit dee08b1999e2 ("arm: Remove
gplugd board"). If no-one else has sent one already I can whip up a
quick patch to remove the dead code.
Update: Patch sent
https://lore.kernel.org/u-boot/20220803234357.21457-1-judge.pack...@gmail.com/
Also as it turns out MVEBU_GPIO is default y and depends on DM_GPIO &&
(ARCH_MVEBU || ARCH_KIRKWOOD) so the Kirkwood boards that are using
DM_GPIO already have it. Disabling KIRKWOOD_GPIO and eventually
removing the driver should be all that is needed.
> --
> Tom
