Hi Sughosh,
>
> > + nimages = CONFIG_FWU_NUM_IMAGES_PER_BANK;
> > + active_bank = mdata->active_index;
> > + img_entry = &mdata->img_entry[0];
> > + for (i = 0; i < nimages; i++) {
> > + img_bank_info = &img_entry[i].img_bank_info[active_bank];
> > + if (!img_bank_info->accepted) {
> > + trial_state = 1;
> > + break;
> > + }
> > + }
>
> Is this used elsewhere in the patchset? The function is starting to
> be big, so perhaps moving this in a static bool "in_trial_state()" or
> similar would make it more readable.
>
There was a discussion about this on the synquacer thread for A/B
updates. Once you split those in a function, it's better to extend
the bootcount API with an EFI backed storage. The reasoning that a
user might disable editing env variables for security reasons and that
device might not be able to preserve RAM or store the counter in CPU
registers across reboots.
If we extend the bootcount API with this code we can plug in the
functionality seamlessly based on the hardware capabilities.
[...]
Regards
/Ilias
