Re: [PATCH v2] xilinx: zynqmp: Do not use 0 as spl bss start address

[Stefan Herbrechtsmeier]

Hi Michal,

Am 07.06.2022 um 10:13 schrieb Michal Simek:
út 7. 6. 2022 v 9:44 odesílatel Stefan Herbrechtsmeier
<stefan.herbrechtsmeier-...@weidmueller.com> napsal:

From: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com>

Do not use 0 as address for memory because of the special meaning for
pointers (null pointer). Change the spl bss start address to the second
page.

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com>

---
The problem was discovered with a static array initialized with zero.
The compiler placed the array at address 0 and thereby a pointer to the
array was interpreted as null pointer.

Changes in v2:
- Rework commit message and replace address null by 0

  include/configs/xilinx_zynqmp.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
index f25d796a1e..21a5cf1617 100644
--- a/include/configs/xilinx_zynqmp.h
+++ b/include/configs/xilinx_zynqmp.h
@@ -209,7 +209,7 @@
  #define CONFIG_SPL_MAX_SIZE            0x40000

  /* Just random location in OCM */
-#define CONFIG_SPL_BSS_START_ADDR      0x0
+#define CONFIG_SPL_BSS_START_ADDR      0x1000
  #define CONFIG_SPL_BSS_MAX_SIZE                0x80000

  #if defined(CONFIG_SPL_SPI_FLASH_SUPPORT)
--
2.30.2


Applied.
M


I think this patch get lost because of the "Convert 
CONFIG_SPL_BSS_START_ADDR to Kconfig" change.

Regards
  Stefan