Hello Neal
On 6/27/22 10:55, Neal Liu wrote:
Reviewed-by: Chia-Wei Wang <chiawei_w...@aspeedtech.com>
The QEMU emulation issue is under investigation by Steven.
The CRC32 and MD5 SW support will be added before we re-enabling HW
crypto drivers.
Chiawei
From: joel.s...@gmail.com <joel.s...@gmail.com> On Behalf Of Joel
Stanley
Sent: Monday, June 27, 2022 3:58 PM
The HACE driver lacks support for all the hash types, causing boot to
fail with the default FIT configuration which uses CRC32.
Additionally the Qemu model or the u-boot driver is unable to
correctly compute the SHA256 hash used in a FIT.
Disable HACE by default while the above issues are worked out to
enable boot testing in Qemu.
I don't think this is the right way to do it.
First, it's fine that drivers can only support some algos. There is no rules
that it must support CRC32.
For CRC32, I understand that the driver should be able to fallback to
the SW implementation. It is not the case today. With some debug in
aspeed_hace_finish() :
U-Boot SPL 2022.07-rc5-dirty (Jun 27 2022 - 09:01:28 +0200)
already initialized, Trying to boot from RAM
## Checking hash(es) for config conf-1 ... OK
## Checking hash(es) for Image firmware-1 ... crc32Unsupported hash algorithm
'crc32' error!
Unsupported hash algorithm for 'hash-1' hash node in 'firmware-1' image node
The above is not related to QEMU.
Thanks,
C.
Second, if Qemu test is failure, it should fix the Qemu HACE driver or disable
it in Qemu, not in common defconfig in u-boot.
This will affect lots of people who use mainline for developments and
productions.
Thanks,
-Neal
Signed-off-by: Joel Stanley <j...@jms.id.au>
---
configs/evb-ast2600_defconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/configs/evb-ast2600_defconfig
b/configs/evb-ast2600_defconfig index f3a6cb222020..160bccff48e2
100644
--- a/configs/evb-ast2600_defconfig
+++ b/configs/evb-ast2600_defconfig
@@ -59,9 +59,6 @@ CONFIG_REGMAP=y
CONFIG_SPL_OF_TRANSLATE=y
CONFIG_CLK=y
CONFIG_SPL_CLK=y
-CONFIG_DM_HASH=y
-CONFIG_HASH_ASPEED=y
-CONFIG_ASPEED_ACRY=y
CONFIG_ASPEED_GPIO=y
CONFIG_DM_I2C=y
CONFIG_MISC=y
--
2.35.1
