Hi Heiko,
On 11/05/22 13:54, Heiko Schocher wrote:
Hello Achath,
On 11.05.22 08:03, Vaishnav Achath wrote:
Currently the SPI flash to load from is defined through the compile
time config CONFIG_SF_DEFAULT_BUS and CONFIG_SF_DEFAULT_CS, this
prevents the loading of binaries from different SPI flash using the
same build.E.g. supporting QSPI flash boot and OSPI flash boot
on J721E platform is not possible due to this limitation.
This commit adds lookup functions spl_spi_boot_bus()
and spl_spi_boot_cs for identifying the flash device based on the
selected boot device, when not overridden the lookup functions are
weakly defined in common/spl/spl_spi.c.
Signed-off-by: Vaishnav Achath <vaishna...@ti.com>
---
you miss here change history. May you want to look into patman tool in
u-boot:/tools/patman/README
which can help you here much.
Noted, sorry I missed this, will wait for further feedback and
include the change history in next revision, please let me
know if a v3 with the change history alone fixed is required.
common/spl/spl_spi.c | 16 +++++++++++++---
include/spl.h | 16 ++++++++++++++++
2 files changed, 29 insertions(+), 3 deletions(-)
Looks fine for me, thanks!
Reviewed-by: Heiko Schocher <h...@denx.de>
Thank you for the review.
bye,
Heiko
--
Regards,
Vaishnav
