> -----Original Message----- > From: Lei Wen [mailto:adrian.w...@gmail.com] > Sent: Tuesday, December 07, 2010 9:02 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Eric Miao; Manas Saksena; Lei Wen; Yu Tang; > Ashish Karkare; Kiran Vedere; Prabhanjan Sarnaik > Subject: Re: [U-Boot] [PATCH v4 6/7] mv-common.h: Add support for > ARMADA100 Platforms > > Hi Prafulla, > > On Wed, Dec 8, 2010 at 1:06 AM, Prafulla Wadaskar <prafu...@marvell.com> > wrote: > > This patch adds commonly used macros for ARMADA100 based > > baords, Also some code reshuffled and updated for typos and comments > > > > Signed-off-by: Prafulla Wadaskar <prafu...@marvell.com> > > --- > > Changelog v3: > > CONFIG_ARCH_CPU_INIT moved out of #ifdef > > > > Changelog v4: > > CONFIG_MFP change to CONFIG_MARVELL_MFP > > some whitespaces removed > > > > include/configs/mv-common.h | 65 ++++++++++++++++++++++++++++++++---- > ------ > > 1 files changed, 49 insertions(+), 16 deletions(-) > > > > diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h > > index 0a76163..067527a 100644 > > --- a/include/configs/mv-common.h > > +++ b/include/configs/mv-common.h > > @@ -39,6 +39,7 @@ > > #define CONFIG_MARVELL 1 > > #define CONFIG_ARM926EJS 1 /* Basic Architecture */ > > > > +/* ====> Kirkwood Platform Common Definations */ > > #if defined(CONFIG_KIRKWOOD) > > #define CONFIG_MD5 /* get_random_hex on krikwood needs MD5 support > */ > > #define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel > */ > > @@ -54,27 +55,45 @@ > > #define CONFIG_SYS_KWD_CONFIG > $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.cfg > > #endif /* CONFIG_SYS_KWD_CONFIG */ > > > > -/* > > - * CONFIG_SYS_TEXT_BASE can be defined in board specific header file, > if needed > > - */ > > -#ifndef CONFIG_SYS_TEXT_BASE > > -#define CONFIG_SYS_TEXT_BASE 0x00600000 > > -#endif /* CONFIG_SYS_TEXT_BASE */ > > +/* Kirkwood has 2k of Security SRAM, use it for SP */ > > +#define CONFIG_SYS_INIT_SP_ADDR 0xC8012000 > > +#define CONFIG_NR_DRAM_BANKS_MAX 2 > > > > #define CONFIG_I2C_MVTWSI_BASE KW_TWSI_BASE > > -#define MV_UART0_BASE KW_UART0_BASE > > +#define MV_UART_CONSOLE_BASE KW_UART0_BASE > > Could we just define the uart base as hard coding one here? For it > must refer to the .h > file in the arch/arm/include directory, which make no sense for the > configure file.
NACK, Console can be on any one of available UART. > > > #define MV_SATA_BASE KW_SATA_BASE > > #define MV_SATA_PORT0_OFFSET KW_SATA_PORT0_OFFSET > > #define MV_SATA_PORT1_OFFSET KW_SATA_PORT1_OFFSET > > > > +/* ====> ARMADA100 Platform Common Definations */ > > I think you probably need to think to seperate armada100 sepecific and > kirkwood specific stuff from mv-common.h now. > For those two kind of definition makes mv-common not so common as it is. NACK, objective of mv-common.h to abstract marvell specific stuff. There is no sense making SoC specific .h ...snip... > > +#define CONFIG_MII /* expose smi ove miiphy interface */ > > #define CONFIG_MVGBE /* Enable Marvell Gbe Controller Driver > */ > > #define CONFIG_SYS_FAULT_ECHO_LINK_DOWN /* detect link using phy > */ > > #define CONFIG_ENV_OVERWRITE /* ethaddr can be reprogrammed */ > > @@ -232,6 +263,7 @@ > > /* > > * File system > > */ > > +#ifndef CONFIG_ARMADA100 /* will be removed latter */ > We may need think how to remove it later now... Sure, when we will support respective peripheral, this will be removed. Regards.. Prafulla . . _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
