On Mon, Apr 25, 2022 at 03:13:53PM +0200, Marek Vasut wrote: > On 4/25/22 15:05, Tom Rini wrote: > > On Mon, Apr 25, 2022 at 03:02:29PM +0200, Marek Vasut wrote: > > > On 4/25/22 14:46, Fabio Estevam wrote: > > > > Hi Marek, > > > > > > > > On 24/04/2022 18:44, Marek Vasut wrote: > > > > > Introduce helper macro UART_BASE_ADDR(n), which returns Nth UART base > > > > > address. Convert all board configurations to this new macro. This is > > > > > the > > > > > first step toward switching CONFIG_MXC_UART_BASE to Kconfig. This is a > > > > > clean up, no functional change. > > > > > > > > As DM_SERIAL is mandatory now, we should get rid of > > > > CONFIG_MXC_UART_BASE. > > > > > > > > I would prefer a patch that removes CONFIG_MXC_UART_BASE instead. > > > > > > DM is mandatory in SPL too ? I doubt it. > > > > It is strongly encouraged, but not mandatory. It is not used on I guess > > imx27/31/5, but is for all of the imx8 families. So > > CONFIG_MXC_UART_BASE still needs to be moved out of board.h files (and > > perhaps out of CONFIG namespace since it's not configurable, it's part > > of the SoC) and perhaps the path for imx8* is to drop the references > > since it's all DM? > > MX8M SPL is not DM serial either. But I think I will just postpone this > cleanup until I have time to finish it.
Right, sorry, I meant DM enabled in SPL to start with. -- Tom
signature.asc
Description: PGP signature