Am 2022-04-20 01:51, schrieb Sean Anderson:
Could you submit a patch there to add your new compatibles?
Sure. I didn't know there was an upstream binding, but I'll try and
add these properties.
If you'll submit the patch(es) before 5.18 is released, I think we
can still add the clock as mandatory.
Esp. because you are using a clock which
isn't described in the upstream binding. I'm curious, do you need the
clock? I only know the LS1028A and it seems you don't have to turn on
any clock there. It might also be the case I've missed something.
You need the clock to set the programming duration properly. See the
probe
function for this driver. For read-only access, it is not necessary.
Ahh thanks, I had a quick glance at your driver and just saw the prepare
clock and enable. I see you are also setting the program pulse width
field. I think it is preset for the LS1028A so in theory it would
work without. In any case, the clock should be added to the binding.
The ta-sfp-prog supply property is also neat :)
-michael
