Hi Han, On Wed, Mar 23, 2022 at 04:24:54PM -0500, Han Xu wrote: > Previous u-boot code changed the default bch setting behavior and caused > backward compatible issue. This fix choose the legacy bch geometry back > again as the default option. If the minimum ecc strength that NAND chips > required need to be chosen, it can be enabled by either adding DT flag > "fsl,use-minimum-ecc" or CONFIG_NAND_MXS_USE_MINIMUM_ECC in configs. The > unused flag "fsl,legacy-bch-geometry" get removed. > > Fixes: 51cdf83eea mtd: gpmi: provide the option to use legacy bch geometry > Fixes: 616f03daba mtd: gpmi: change the BCH layout setting for large oob NAND > Tested-by: Tim Harvey <thar...@gateworks.com> Tested-by: Sean Nyekjaer <s...@geanix.com> > Signed-off-by: Han Xu <han...@nxp.com> > > Changes in v2: > -- change the commit log about backward compatible issue is in u-boot > -- removed the unused flag > -- add fixes and test tag > ---
Changes ^ should be below the --- in order to be skipped from the commit msg. > drivers/mtd/nand/raw/mxs_nand.c | 71 ++++++++++++++++++++++++++---- > drivers/mtd/nand/raw/mxs_nand_dt.c | 2 - > include/mxs_nand.h | 2 - > 3 files changed, 62 insertions(+), 13 deletions(-) > [ ... ] I have only tested this with the legacy option. It seem to work :) Thanks for finally fixing the Linux vs. U-boot unalignment. /Sean
