On Wed, Mar 23, 2022 at 8:14 AM Tom Rini <tr...@konsulko.com> wrote: > > On Tue, Mar 22, 2022 at 01:34:34PM +0100, Heiko Thiery wrote: > > Hi Tom, > > > > > > Am Di., 22. März 2022 um 13:25 Uhr schrieb Tom Rini <tr...@konsulko.com>: > > > > > > On Tue, Mar 22, 2022 at 10:25:12AM +0100, Heinrich Schuchardt wrote: > > > > On 3/21/22 15:26, Heiko Thiery wrote: > > > > > It was observed that enabling additional DM modules the configured > > > > > malloc value is not sufficient. So lets increase the value. > > > > > > > > > > Signed-off-by: Heiko Thiery <heiko.thi...@gmail.com> > > > > > --- > > > > > v2: > > > > > - add a more proper commit message to explan why the value was > > > > > increased > > > > > > > > > > configs/kontron_pitx_imx8m_defconfig | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/configs/kontron_pitx_imx8m_defconfig > > > > > b/configs/kontron_pitx_imx8m_defconfig > > > > > index 76430213e3..30c3586937 100644 > > > > > --- a/configs/kontron_pitx_imx8m_defconfig > > > > > +++ b/configs/kontron_pitx_imx8m_defconfig > > > > > @@ -2,6 +2,7 @@ CONFIG_ARM=y > > > > > CONFIG_ARCH_IMX8M=y > > > > > CONFIG_SYS_TEXT_BASE=0x40200000 > > > > > CONFIG_SYS_MALLOC_LEN=0x600000 > > > > > +CONFIG_SYS_MALLOC_F_LEN=0x10000 > > > > > > > > @Heiko > > > > Should we really adjust this on board level? Won't we have the same > > > > problem on all imx8m boards? > > > > > > > > Why don't you change the default for all i.mx8 boards in /Kconfig? > > > > > > > > @Tom, @Simon > > > > Shouldn't we replace the default of 0x400 by 0x2000 generally? > > > > > > That's well more than the default for imx8 of 0x2000 and even for the > > > default for sandbox of 0x4000, does it need to be that huge? Or was > > > that the "I'm sick of this problem" value? > > > > > > > I did test a pending patch that enables a DM clock driver for the > > imx8mq. With that patch a huge amount of memory seems to be needed for > > all that clock infrastructure. > > OK, then we should adjust upwards the default for imx8 in the toplevel > Kconfig.
I have been using 0x10000 for a while without issue on both an imx8mm and imx8mn. When I used that value, it was more of a desire to overshoot the minimal requirements so as features are added, we don't have to keep adjusting the memory. I support making it the platform default. adam > > -- > Tom
