On Fri, Mar 11, 2022 at 01:09:08PM +0100, Lukasz Majewski wrote:
> Hi Tom,
> 
> > On Tue, Feb 22, 2022 at 09:03:58AM +0100, Lukasz Majewski wrote:
> > > Up till now the CONFIG_POWER_TPS65217 has been defined in several
> > > header files for am335x SoC.
> > > 
> > > This patch renames it to CONFIG_PMIC_TPS65217, which better
> > > reflects the role of this IC circuit.
> > > 
> > > Signed-off-by: Lukasz Majewski <[email protected]>
> > > Reviewed-by: Jaehoon Chung <[email protected]>
> > > ---
> > > 
> > >  drivers/power/pmic/Makefile         | 2 +-
> > >  include/configs/am335x_evm.h        | 2 +-
> > >  include/configs/am335x_guardian.h   | 2 +-
> > >  include/configs/am335x_shc.h        | 2 +-
> > >  include/configs/am335x_sl50.h       | 2 +-
> > >  include/configs/brppt1.h            | 2 +-
> > >  include/configs/bur_am335x_common.h | 2 +-
> > >  include/configs/chiliboard.h        | 2 +-
> > >  scripts/config_whitelist.txt        | 2 +-
> > >  9 files changed, 9 insertions(+), 9 deletions(-)  
> > 
> > This needs to be migrated to Kconfig fully / correctly as well, not
> > just changing the whitelist entry.
> > 
> 
> But there is follow up patch, which adds proper entry to Kconfig with
> new name:
> 
> https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
> 
> The idea was to first rename the CONFIG_POWER_TPS65217 to
> CONFIG_PMIC_TPS65217 (as a single patch) and then provide DM support
> for TPS65217 with proper (renamed) Kconfig entry.

Please re-order the series so we don't do what you're doing here and be
sure to fully migrate everyone.  I noticed this as part of finding and
fixing:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
yesterday and saw a bunch of PMIC symbols get listed.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to