On Mon, Feb 14, 2022 at 9:08 AM Peng Fan (OSS) <peng....@oss.nxp.com> wrote: > > From: Clark Wang <xiaoning.w...@nxp.com> > > Add i3c controller clock enable/disable function for imx8ulp. > > Reviewed-by: Ye Li <ye...@nxp.com> > Signed-off-by: Clark Wang <xiaoning.w...@nxp.com> > Signed-off-by: Peng Fan <peng....@nxp.com> > --- > arch/arm/mach-imx/imx8ulp/clock.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/mach-imx/imx8ulp/clock.c > b/arch/arm/mach-imx/imx8ulp/clock.c > index 91580b2c29..6f52ccee34 100644 > --- a/arch/arm/mach-imx/imx8ulp/clock.c > +++ b/arch/arm/mach-imx/imx8ulp/clock.c > @@ -237,6 +237,32 @@ u32 imx_get_i2cclk(u32 i2c_num) > } > #endif > > +#if IS_ENABLED(CONFIG_SYS_I2C_IMX_I3C) > +int enable_i3c_clk(unsigned char enable, u32 i3c_num) > +{ > + if (i3c_num != 8)
What does this magic 8 mean? Please replace with some more meaningful define. > +u32 imx_get_i3cclk(u32 i3c_num) > +{ > + if (i3c_num != 8) Same here.