Hi Pali, Works great! I've tested this patch using dumpimage for the following boards:
HP Thin Client T5335z Marvell Dove board: RD-88AP510-Avengers SoC: 88AP510 (A1) 1Ghz CPU, 1GB RAM Dell Kace M300 Marvell Kirkwood board: DB-88F6282A-BP LE SoC: Armada 300 ( aka 88F6282) 2GHz CPU, 2GB RAM Thanks! Tested-by: Tony Dinh <mibo...@gmail.com> On Tue, Feb 15, 2022 at 10:59 AM Pali Rohár <p...@kernel.org> wrote: > > This patch series extends kwbimage v0 format support by providing > ability to dump content of Dove boot images (extension of v0 format). > It also fixes recognition of these images in kwboot utility (as it uses > macros and inline functions from kwbimage.h header file). > > Implementation is based on 88AP510 Functional Specifications, > Chapter 5.2 Boot Image Format, which is publicly available at: > https://web.archive.org/web/20120130172443/https://www.marvell.com/application-processors/armada-500/assets/Armada-510-Functional-Spec.pdf > > Printing information about image.kwb is possible by: > > $ ./tools/dumpimage -l image.kwb > > Dumping image.kwb is possible by commands: > > $ ./tools/dumpimage -T kwbimage -p -1 -o image.cfg image.kwb > $ ./tools/dumpimage -T kwbimage -p 0 -o data.bin image.kwb > $ ./tools/dumpimage -T kwbimage -p 1 -o binary1.bin image.kwb > $ ./tools/dumpimage -T kwbimage -p 2 -o binary2.bin image.kwb > ... > (where -p N is Nth binary executable header, e.g. SPL) > > Dove images contains more sections which in config file begins with line > "MATCH ADDRESS 0xaddr MASK 0xmask VALUE 0xval" and means that section is > executed only when check ((readl(addr) & mask) == (val & mask)) passes. > > Support for generating these kind of images is not provided. > I hope that this patch series helps somebody else to implement it. > > Pali Rohár (7): > tools: kwbimage: Define structures for extended kwbimage v0 headers > tools: kwbimage: Fix calculating size of kwbimage v0 header > tools: kwbimage: Add support for dumping extended and binary v0 > headers > tools: kwbimage: Do not show mkimage error message in dumpimage > tools: kwbimage: Add support for NAND_BLKSZ and NAND_BADBLK_LOCATION > for v0 images > tools: kwbimage: Fix help how to extract DDR3 training code > tools: kwbimage: Add me as an author of kwbimage > > tools/kwbimage.c | 139 ++++++++++++++++++++++++++++++++++++++++++----- > tools/kwbimage.h | 116 +++++++++++++++++++++++++++++++++++---- > 2 files changed, 231 insertions(+), 24 deletions(-) > > -- > 2.20.1 >
