On 12.02.22 12:50, Ramon Fried wrote: > On Wed, Feb 9, 2022 at 5:41 PM Daniel Klauer <daniel.kla...@gin.de> wrote: >> >> The miiphy_read/miiphy_write functions return 1 on error, not -errno. > Why don't you just fix the miiphy_read/miiphy_write functions ?
Other functions from that module do the same, so I assumed it's intentional. It could be fixed too though, with a corresponding fix up of the few callers that expect the positive return value on error.
