Hi Rogier
On 2/7/22 23:56, Rogier Stam wrote:
Hi
Per Pali's comments adapted the patch. This one also includes the
changes necessary for storing ENV in FAT. I also added CONFIG_SCSI for
both ext4 and fat should anyone want to use SCSI instead of AHCI.
I have 2 comments, more related to formal patch submission.
a) Could you please send patches in-lined, best formatted via
"git format-patch" and sent via "git send-email". Otherwise
its harder to review and comment the patches.
b) Split you patch into 2 logically separated patches. One handling
the common "env" files and one handling the Espressobin related
files.
Thanks,
Stefan
Regards
Rogier
On 07-02-2022 09:11, Rogier Stam wrote:
Hi
I was attemting to boot from SATA on an Espressobin. As such I wanted
to store the Environment in a SATA partition and not in the SPI flash.
In order to get this running I had to make a few changes, as the
original code assumes the Environment is always in SPI flash.
Additionally I also had to force scsci_scan to ensure the AHCI disk /
partitions could be found.
Hope it will be considered to merge
Regards
Rogier Stam
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de
