Hi Alper, On Sun, 6 Feb 2022 at 14:03, Alper Nebi Yasak <alpernebiya...@gmail.com> wrote: > > I've managed to build images like in doc/chromium/chainload.rst wtih > binman, but ran into an issue with entry expansion in FIT and worked on > it a bit. I also added SetImagePos() because that documentation asks for > precise placement of u-boot.bin inside the FIT and I felt like doing it > as an easier way to know the positions. > > I would try to refactor and experiment with FIT things more, but I know > Simon's currently working on converting SPL_FIT_GENERATOR to binman. > Instead I'm just sending things I have already done with some tests > added, hopefully without too many conflicts.
We'll see, but I'll apply this first in any case, to save you the trouble. This all looks good. I've made a few comments which can be tidied up now or later. I was hoping to send my series out this morning but I didn't get much time over the weekend, so it might be another week. Hopefully not. > > > Alper Nebi Yasak (5): > binman: Fix subentry expansion for FIT entry type > binman: Register and check bintools from FIT subentries > binman: Check missing bintools of Section subclasses > binman: Convert FIT entry type to a subclass of Section entry type > binman: Update image positions of FIT subentries > > tools/binman/etype/fit.py | 90 ++++++--- > tools/binman/etype/section.py | 1 + > tools/binman/ftest.py | 183 ++++++++++++++++++ > .../binman/test/220_fit_subentry_bintool.dts | 39 ++++ > 4 files changed, 287 insertions(+), 26 deletions(-) > create mode 100644 tools/binman/test/220_fit_subentry_bintool.dts > > -- > 2.34.1 > Regards, Simon
