On Fri, Feb 04, 2022 at 11:56:52AM +0100, Pali Rohár wrote: > On Thursday 03 February 2022 15:02:02 Simon Glass wrote: > > Hi, > > > > On Thu, 3 Feb 2022 at 14:53, Tom Rini <tr...@konsulko.com> wrote: > > > > > > On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote: > > > > On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote: > > > > > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Rohár wrote: > > > > > > > > > > > Signed-off-by: Pali Rohár <p...@kernel.org> > > > > > > --- > > > > > > > > > > > > I would really appreciate if U-Boot test framework starts printing > > > > > > deprecation warnings, instead of sending patches which directly drop > > > > > > support for some boards. > > > > > > > > > > > > There is absolutely no warning during building U-Boot for RX-51 > > > > > > board > > > > > > that this board has not been converted to DM_KEYBOARD yet. > > > > > > > > > > Please send some patch that implements what you're wanting to see for > > > > > how to make the warnings more visible. I do agree the warning for > > > > > v2022.10 only showed up after the merge to -next once v2022.01 came > > > > > out, > > > > > but it's still a fairly long time to clean up the few unconverted > > > > > boards. > > > > > > > > Oh, I see what's going on. Simon, the DM_KEYBOARD check isn't > > > > triggering for any boards. I'll look more. > > > > > > And here's where we're at. nokia_rx51 doesn't set CONFIG_KEYBOARD, so > > > didn't trigger the warning about migration. Every platform that sets > > > CONFIG_KEYBOARD is migrated. I don't know how many other platforms are > > > in the situation nokia_rx51 is in. Yanking out the legacy code and > > > seeing what fails to build, and going from there is probably the next > > > option. > > > > Yes. > > > > As to your questoin, none that I know of. I sent a series to drop > > cfb_console which was how this used to work, although in fact it > > hasn't worked for a while. The problem here seems to be that this > > board was multiple migrations behind and so was not caught. > > It is not truth that cfb_console has not worked. This driver is / was > working fine on n900 without any issues.
Yes, it's such an old missed migration that there's no check for it. > > We should be able to remove the migration check. > > > > Pali, just to explain from the other POV, I am finding it increasingly > > frustrating dealing with ad-hoc CONFIG options, old drivers, etc. We > > really need to complete some of the migrations we started 6 years ago. > > > > Regards, > > Simon > > Well, I see and understand you. But as I explained it more times, it was > me who is/was waiting for review of n900 patches and I was not able to > speed up review process. There was always some n900 patch in waiting > state. > > Now when pending n900 patches were reviewed and merged, I prepared and > sent another one -- this DM_KEYBOARD which removes one part of > cfb_console code from n900 board code. Alright. So, do you see the warning about DM_SERIAL? Are you going to start work on that migration now, or in about a week or two when I pick this up, assuming no changes are requested? -- Tom
signature.asc
Description: PGP signature
