On Tue, 23 Nov 2010 12:45:04 -0600 Scott Wood <scottw...@freescale.com> wrote:
> On Tue, 23 Nov 2010 19:16:47 +0100 > Stefan Roese <s...@denx.de> wrote: > > > Hi Scott, > > > > On Tuesday 23 November 2010 18:27:08 Scott Wood wrote: > > > > Without this fix, the NAND_SPL target (in nand_spl/) is not built > > > > at all. > > > > > > > > Signed-off-by: Stefan Roese <s...@denx.de> > > > > > > It builds for me without it, on mpc8315erdb (I tried some 4xx boards > > > but they don't build at all), as of current master branch > > > (fa722ea76be565de6823ca04c107cc4fbd96b776). Applying this change stops > > > it from building. > > > > Yes, current git head fails to build an many 4xx boards. My patch is on top > > of > > Wolfgangs patchset "[PATCH 0/7] Address partial linking issues" from > > 2010-11-21 which fixes most of the 4xx problems. But without this patch, no > > object was built in the nand_spl directory at all. Not sure if I overlooked > > something though. > > Perhaps it has to do with the 4xx boards having NAND_U_BOOT directly in > boards.cfg, while the Freescale boards typically have NAND there, and > define NAND_U_BOOT in the makefile. > > I think the proper fix is to figure out how those quotes are being > injected into the make variable. Try removing the "=y" in boards.cfg. tools/scripts/define2mk.sed will add quotes to things that aren't numbers, but it has special handling to turn empty defines (or the number 1) into an unquoted y. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
