Re: [PATCH v4 03/13] mmc: fsl: Use brackets around if()

[Minkyu Kang]

Hi!

2022년 1월 17일 (월) 08:50, Jaehoon Chung <jh80.ch...@samsung.com>님이 작성:

> On 1/17/22 5:19 AM, Simon Glass wrote:
> > At present the IS_ENABLED() macro has extra brackets, making it possible
> > to write:
> >
> >    if IS_ENABLED(CONFIG_XXX)
> >
> > but it is a bit confusing. Add the missing brackets.
> >
> > Signed-off-by: Simon Glass <s...@chromium.org>
>
> Reviewed-by: Jaehoon Chung <jh80.ch...@samsung.com>
>
> Best Regards,
> Jaehoon Chung


Reviewed-by: Minkyu Kang <mk7.k...@samsung.com>


>
> > ---
> >
> > (no changes since v1)
> >
> >  drivers/mmc/fsl_esdhc_imx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c
> > index 9299635f509..08ea98fe81a 100644
> > --- a/drivers/mmc/fsl_esdhc_imx.c
> > +++ b/drivers/mmc/fsl_esdhc_imx.c
> > @@ -453,7 +453,7 @@ static int esdhc_send_cmd_common(struct
> fsl_esdhc_priv *priv, struct mmc *mmc,
> >
> >       /* Send the command */
> >       esdhc_write32(&regs->cmdarg, cmd->cmdarg);
> > -     if IS_ENABLED(CONFIG_FSL_USDHC) {
> > +     if (IS_ENABLED(CONFIG_FSL_USDHC)) {
> >               u32 mixctrl = esdhc_read32(&regs->mixctrl);
> >
> >               esdhc_write32(&regs->mixctrl,
> >
>
> --
Thanks. Minkyu Kang.