Hi Simon,

On 12/28/21 9:32 AM, Simon Glass wrote:
On Tue, 14 Dec 2021 at 09:57, Patrick Delaunay
<patrick.delau...@foss.st.com> wrote:
This converts the following to Kconfig:
    CONFIG_AT91_EFLASH

Signed-off-by: Patrick Delaunay <patrick.delau...@foss.st.com>
---

  arch/arm/mach-at91/Kconfig   | 8 ++++++++
  configs/ethernut5_defconfig  | 2 +-
  include/configs/ethernut5.h  | 1 -
  scripts/config_whitelist.txt | 1 -
  4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 4448ca1592..5267a7d15d 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -302,6 +302,14 @@ config ATMEL_SFR
  config SYS_SOC
         default "at91"

+config AT91_EFLASH
+       bool "Support AT91 flash driver"
+       depends on AT91SAM9XE
+       select USE_SYS_MAX_FLASH_BANKS
+       help
+         Enable the driver for the enhanced embedded flash in the Atmel
+         AT91SAM9XE devices.
Reviewed-by: Simon Glass <s...@chromium.org>

Please describe what it actually means. Enhanced in what way?

I will dropped the "enhanced" word, copied for header
of arch/arm/mach-at91/arm926ejs/eflash.c


/*
 * this driver supports the enhanced embedded flash in the Atmel
 * AT91SAM9XE devices with the following geometry:
 *
 * AT91SAM9XE128: 1 plane of  8 regions of 32 pages (total  256 pages)
 * AT91SAM9XE256: 1 plane of 16 regions of 32 pages (total  512 pages)
 * AT91SAM9XE512: 1 plane of 32 regions of 32 pages (total 1024 pages)
 * (the exact geometry is read from the flash at runtime, so any
 *  future devices should already be covered)

....


but not present in commit header

d88bebe16d81 ("AT91SAM9XE: add embedded flash support")


It is more clear


Regards,
Simon


Thanks

Patrick

Reply via email to