Hello Tommaso, > -----Original Message----- > From: Tommaso Merciai <tomm.merc...@gmail.com> > Sent: Friday, November 26, 2021 6:43 PM > Cc: mich...@amarulasolutions.com; ZHIZHIKIN Andrey <andrey.zhizhikin@leica- > geosystems.com>; Tommaso Merciai <tomm.merc...@gmail.com>; Stefano Babic > <sba...@denx.de>; Fabio Estevam <feste...@gmail.com>; NXP i.MX U-Boot Team > <uboot-...@nxp.com>; Peng Fan <peng....@nxp.com>; Ye Li <ye...@nxp.com>; Marek > Vasut <ma...@denx.de>; Simon Glass <s...@chromium.org>; Frieder Schrempf > <frieder.schre...@kontron.de>; Marek Behún <marek.be...@nic.cz>; Ying-Chun Liu > (PaulLiu) <paul...@debian.org>; u-boot@lists.denx.de > Subject: [RFC PATCH 0/3] imx8m: move env_get_location for imx8mn and imx8mp at > board level > > > This series move env_get_location from soc to board level. As suggested > by Michael <mich...@amarulasolutions.com> make no sense to define an > unique way for multiple board. One board can boot from emmc and having > env on spi flash etc.. Anyways, this function is kept in both imx8mn > and imx8mp evk boards instead of being completely dropped. > (as suggested by Andrey <andrey.zhizhi...@leica-geosystems.com>)
I believe there has been another suggestion from my side regarding this patch: Since it look like that Michael Trimarchi submitted another part to drop env_get_offset() in [1], combined with the first patch in this series - it is a complete revert of 2707faf01f ("imx8mn/imx8mp: override env_get_offset and env_get_location"). I suggest you to submit a revert instead of your first patch and deprecate the patch from Michael, instead of having 2 separate patches for this. > > Tommaso Merciai (3): > imx8m: drop env_get_location for imx8mn and imx8mp > imx: imx8mn_evk: override env_get_location > imx: imx8mp_evk: override env_get_location > > arch/arm/mach-imx/imx8m/soc.c | 39 ----------------------- > board/freescale/imx8mn_evk/imx8mn_evk.c | 42 +++++++++++++++++++++++++ > board/freescale/imx8mp_evk/imx8mp_evk.c | 41 ++++++++++++++++++++++++ > 3 files changed, 83 insertions(+), 39 deletions(-) > > -- > 2.25.1 Link: [1]: http://patchwork.ozlabs.org/project/uboot/patch/20211117143456.34441-1-mich...@amarulasolutions.com/ -- andrey