On Sat, Nov 13, 2021 at 11:15:54AM -0700, Simon Glass wrote: > On Tue, 9 Nov 2021 at 00:02, Ilias Apalodimas > <ilias.apalodi...@linaro.org> wrote: > > > > There's a lot of code duplication in U-Boot right now. All the TPM TIS > > compatible drivers we have at the moment have their own copy of a TIS > > implementation. > > > > So let's create a common layer which implements the core TIS functions. > > Any driver added from now own, which is compatible with the TIS spec, will > > only have to provide the underlying bus communication mechanisms. > > > > Signed-off-by: Ilias Apalodimas <ilias.apalodi...@linaro.org> > > --- > > drivers/tpm/tpm2_tis_core.c | 463 ++++++++++++++++++++++++++++++++++++ > > drivers/tpm/tpm_tis.h | 136 +++++++++++ > > include/tpm-v2.h | 1 + > > 3 files changed, 600 insertions(+) > > create mode 100644 drivers/tpm/tpm2_tis_core.c > > > > Please can you add a change log to each patch? You have a vague one in > the cover letter but I am left to guess how each patch has changed.
Will do. On this one specifically I fixed the @return missing info on the documentation Thanks /Ilias > > Reviewed-by: Simon Glass <s...@chromium.org> > > Regards, > Simon
