Hi, On Wed, 20 Oct 2021 at 01:17, Rasmus Villemoes <rasmus.villem...@prevas.dk> wrote: > > On 20/08/2021 20.18, Simon Glass wrote: > > Hi Harm, > > > > On Wed, 18 Aug 2021 at 08:09, Harm Berntsen <harm.bernt...@nedap.com> wrote: > >> > >> On Thu, 2021-05-13 at 19:39 -0600, Simon Glass wrote: > >>> int clk_uclass_post_probe(struct udevice *dev) > >>> { > >>> + int ret; > >>> + > >>> /* > >>> * when a clock provider is probed. Call clk_set_defaults() > >>> * also after the device is probed. This takes care of cases > >>> * where the DT is used to setup default parents and rates > >>> * using assigned-clocks > >>> */ > >>> - clk_set_defaults(dev, 1); > >>> + ret = clk_set_defaults(dev, 1); > >>> + if (ret) > >>> + return log_ret(ret); > >>> > >>> return 0; > >>> } > >> > >> Note that this patch broke booting my imx8mn based board on U-Boot > >> v2021.10-rc2. > > I just ran into the same issue with v2021.10 being broken for > imx8mp_evk, and git bisect pointing at this commit, symptoms being > > U-Boot 2021.10 (Oct 20 2021 - 08:45:51 +0200) > > CPU: Freescale i.MX8MP[8] rev1.1 at 1200 MHz > ... > MMC: mmc@30b50000 - probe failed: -2 > mmc@30b60000 - probe failed: -2 > > Reverting 92f1e9a4b on top of v2021.10 yields > > U-Boot 2021.10-00001-gac2520a138 (Oct 20 2021 - 09:05:48 +0200) > > CPU: Freescale i.MX8MP[8] rev1.1 at 1200 MHz > ... > MMC: FSL_SDHC: 1, FSL_SDHC: 2 > > cc += imx maintainers, this should not still be broken 2 months (and a > release) after it was reported.
I see a patch to explicitly make this optional, using the devicetree. Regards, Simon