On 18/10/21 03:30AM, Kris Chaplin wrote:
> The mt25qu512a supports 4K or 64K sectors, so adding SECT_4K to enable 4K
> sector usage.
>
> Datasheet:
> https://media-www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/n25q/n25q_512mb_1ce_3v_65nm.pdf
>
> Tested on Intel n5x hardware with QSPI carrier card
>
> Signed-off-by: Kris Chaplin <kris.chap...@linux.intel.com>
> Tested by: Kris Chaplin <kris.chap...@linux.intel.com>
This is unusual. The patch should *always* be tested by the author so
you don't really need a Tested-by from the author. It is implied.
You should also Cc the subsystem maintainers so that they can see the
patch and review and apply it. You can use `./scripts/get_maintainer.pl
<patch_file.patch>` to get the list of people who need to be in Cc.
Adding Jagan and Vignesh for this patch.
Anyway, with the Tested-by trailer dropped,
Acked-by: Pratyush Yadav <p.ya...@ti.com>
> ---
> drivers/mtd/spi/spi-nor-ids.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index f0c8041997..5359d09489 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -190,7 +190,7 @@ const struct flash_info spi_nor_ids[] = {
> { INFO6("mt25qu256a", 0x20bb19, 0x104400, 64 * 1024, 512, SECT_4K |
> SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES | USE_FSR) },
> { INFO("n25q256ax1", 0x20bb19, 0, 64 * 1024, 512, SECT_4K |
> SPI_NOR_QUAD_READ | USE_FSR) },
> { INFO6("mt25qu512a", 0x20bb20, 0x104400, 64 * 1024, 1024,
> - SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES |
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_4B_OPCODES |
> USE_FSR) },
> { INFO("n25q512a", 0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR |
> SPI_NOR_QUAD_READ) },
> { INFO6("mt25ql512a", 0x20ba20, 0x104400, 64 * 1024, 1024, SECT_4K |
> USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> --
> 2.25.1
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
