On Tue, 19 Oct 2021 09:52:14 -0600 Simon Glass <s...@chromium.org> wrote:
> Hi Marek, > > On Tue, 19 Oct 2021 at 08:32, Marek Behún <marek.be...@nic.cz> wrote: > > > > On Mon, 18 Oct 2021 12:13:19 -0600 > > Simon Glass <s...@chromium.org> wrote: > > > > > --- /dev/null > > > +++ b/board/sandbox/sandbox.env > > > @@ -0,0 +1,25 @@ > > > +stdin=serial > > > +#ifdef CONFIG_SANDBOX_SDL > > > +stdin+=,cros-ec-keyb,usbkbd > > > > this was CONFIG_KEYBOARD and now is CONFIG_SANDBOX_SDL, is this okay? > > The old code is: > > #ifdef CONFIG_SANDBOX_SDL > #define LCD_BPP LCD_COLOR16 > #define CONFIG_LCD_BMP_RLE8 > > #define CONFIG_KEYBOARD > > #define SANDBOX_SERIAL_SETTINGS "stdin=serial,cros-ec-keyb,usbkbd\0" \ > "stdout=serial,vidconsole\0" \ > "stderr=serial,vidconsole\0" > #else > #define SANDBOX_SERIAL_SETTINGS "stdin=serial\0" \ > "stdout=serial,vidconsole\0" \ > "stderr=serial,vidconsole\0" > #endif > > > so really the check is on CONFIG_SANDBOX_SDL. The setting of > CONFIG_KEYBOARD is not related to the environment. Ah, sorry. In that case Reviewed-by: Marek Behún <marek.be...@nic.cz>
