Hi, On Mon, 4 Oct 2021 at 23:40, Gaurav Jain <gaurav.j...@nxp.com> wrote: > > added device tree support for job ring driver. > sec is initialized based on job ring information processed > from device tree. > > Signed-off-by: Gaurav Jain <gaurav.j...@nxp.com> > Reviewed-by: Ye Li <ye...@nxp.com> > --- > cmd/Kconfig | 1 + > drivers/crypto/fsl/Kconfig | 7 + > drivers/crypto/fsl/Makefile | 3 +- > drivers/crypto/fsl/jr.c | 318 ++++++++++++++++++++++++------------ > drivers/crypto/fsl/jr.h | 14 ++ > 5 files changed, 233 insertions(+), 110 deletions(-)
This does not look like a proper driver to me, as it has an exported function sec_init_idx(). What operations does it perform? Should it have a uclass? Regards, Simon