Hi Marcel,
On Wed, 6 Oct 2021 at 15:28, Marcel Ziswiler <mar...@ziswiler.com> wrote:
>
> From: Marcel Ziswiler <marcel.ziswi...@toradex.com>
>
> Use binman to pack images.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswi...@toradex.com>
> Reviewed-by: Heiko Thiery <heiko.thi...@gmail.com>
> Reviewed-by: Fabio Estevam <feste...@gmail.com>
> Reviewed-by: Heiko Schocher <h...@denx.de>
>
> ---
>
> Changes in v4:
> - Add Heiko Schocher's reviewed-by tag.
> - Fix copyright periods.
>
> Changes in v3:
> - Case fold hex string.
> - Revert binman part of imx8mm-verdin-u-boot.dtsi to a plain copy from
> imx8mm-evk and postpone further improvements to after migrating to a
> common binman config as agreed with Frieder and Simon.
>
> Changes in v2:
> - Explicitly pass filename to binman when generating binaries as
> suggested by Heiko.
> - Use proper intermediate binary u-boot-spl-ddr.bin for imximage as
> pointed out by Heiko.
>
> arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 124 ++++++++++++++++++++++-
> arch/arm/mach-imx/imx8m/Kconfig | 1 +
> board/toradex/verdin-imx8mm/imximage.cfg | 11 +-
> configs/verdin-imx8mm_defconfig | 2 +-
> doc/board/toradex/verdin-imx8mm.rst | 53 +++++-----
> 5 files changed, 157 insertions(+), 34 deletions(-)
Nice clean-up!
Reviewed-by: Simon Glass <s...@chromium.org>
Option below.
>
> diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
> b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
> index a97626fa0c1..0c65070cd5f 100644
> --- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
> @@ -1,11 +1,15 @@
> // SPDX-License-Identifier: GPL-2.0+ OR MIT
> /*
> - * Copyright 2020 Toradex
> + * Copyright 2020-2021 Toradex
> */
>
> #include "imx8mm-u-boot.dtsi"
>
> / {
> + binman: binman {
> + multiple-images;
> + };
> +
> firmware {
> optee {
> compatible = "linaro,optee-tz";
> @@ -91,3 +95,121 @@
> &wdog1 {
> u-boot,dm-spl;
> };
> +
> +&binman {
> + u-boot-spl-ddr {
> + filename = "u-boot-spl-ddr.bin";
> + pad-byte = <0xff>;
> + align-size = <4>;
> + align = <4>;
> +
> + u-boot-spl {
> + align-end = <4>;
> + };
> +
> + blob_1: blob-ext@1 {
> + filename = "lpddr4_pmu_train_1d_imem.bin";
> + size = <0x8000>;
> + };
You can use the 'type' if you like, so you don't need the @:
blob_1: 1d-imem {
type = "blob-ext";
filename = "...";
...
Regards,
Simon
