> From: Bin Meng <bmeng...@gmail.com>
> Sent: Saturday, September 11, 2021 10:31 PM
> To: Zong Li <zong...@sifive.com>; Leo Yu-Chi Liang(梁育齊) 
> <ycli...@andestech.com>; Rick Jian-Zhi Chen(陳建志) <r...@andestech.com>; 
> u-boot@lists.denx.de
> Subject: [PATCH v2] board: sifive: Fix a potential build warning in 
> board_fdt_blob_setup()
>
> Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in u-boot 
> proper") added a board-specific implementation of board_fdt_blob_setup() 
> which takes a pointer as the return value, but it does not return anything if 
> CONFIG_OF_SEPARATE is not enabled. This will cause a build warning seen when 
> testing booting S-mode U-Boot directly from QEMU, per the instructions in [1]:
>
>   board/sifive/unleashed/unleashed.c: In function ‘board_fdt_blob_setup’:
>   board/sifive/unleashed/unleashed.c:125:1: warning: control reaches end of 
> non-void function [-Wreturn-type]
>
> Return &_end as the default case.
>
> [1] 
> https://qemu.readthedocs.io/en/latest/system/riscv/sifive_u.html#running-u-boot
>
> Signed-off-by: Bin Meng <bmeng...@gmail.com>
>
> ---
>
> Changes in v2:
> - Correct the commit title
>
>  board/sifive/unleashed/unleashed.c | 4 ++--  
> board/sifive/unmatched/unmatched.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Rick Chen <r...@andestech.com>

Reply via email to