Hello Pali, On Fri, Aug 13, 2021 at 11:31 AM Pali Rohár <p...@kernel.org> wrote: > > On Friday 13 August 2021 10:59:33 Luka Kovacic wrote: > > Hello Pali, > > > > On Fri, Aug 13, 2021 at 10:08 AM Pali Rohár <p...@kernel.org> wrote: > > > > > > On Friday 13 August 2021 01:39:37 Luka Kovacic wrote: > > > > Add the loadaddr U-Boot environment variable, as this is available in > > > > the stock Marvell U-Boot by default on Marvell Armada A37XX platforms. > > > > > > Hello Luka! Why is this change needed? Reason that it is in historic > > > vendor U-Boot does not mean that it has to be also in new mainline > > > version. > > > > > > I have already wrote some reasons in previous review thread: > > > https://lore.kernel.org/u-boot/20210301150505.3iajeeufi7ahsnk3@pali/ > > > > > > I think this change was needed when CONFIG_SYS_LOAD_ADDR was set to > > > incorrect value, which is already fixed in mainline U-Boot. > > > > This value is very useful when building custom Linux boot scripts. > > Yesterday, I booted the board without this patch and there was no loadaddr > > variable. > > > > Do I understand this correctly? Are you saying that the value in the > > loadaddr > > variable should be automatically inherited from CONFIG_SYS_LOAD_ADDR > > even without this patch? > > If you do not specify load address then address from > CONFIG_SYS_LOAD_ADDR is used. But as I mentioned in above email, > CONFIG_SYS_LOAD_ADDR was defined incorrectly and which cause that it did > not worked and caused crashes...
I tried not specifying it and then the loadaddr variable doesn't even exist. > > > > > > > > Signed-off-by: Luka Kovacic <luka.kova...@sartura.hr> > > > > Cc: Luka Perkov <luka.per...@sartura.hr> > > > > Cc: Robert Marko <robert.ma...@sartura.hr> > > > > --- > > > > include/configs/mvebu_armada-37xx.h | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/include/configs/mvebu_armada-37xx.h > > > > b/include/configs/mvebu_armada-37xx.h > > > > index 8e8bcfa018..6901680e32 100644 > > > > --- a/include/configs/mvebu_armada-37xx.h > > > > +++ b/include/configs/mvebu_armada-37xx.h > > > > @@ -110,6 +110,7 @@ > > > > > > > > /* fdt_addr and kernel_addr are needed for existing distribution boot > > > > scripts */ > > > > #define CONFIG_EXTRA_ENV_SETTINGS \ > > > > + "loadaddr=0x6000000\0" \ > > > > "scriptaddr=0x6d00000\0" \ > > > > "pxefile_addr_r=0x6e00000\0" \ > > > > "fdt_addr=0x6f00000\0" \ > > > > -- > > > > 2.31.1 > > > > > > > > Kind regards, > > Luka Kind regards, Luka
