On Tue, 29 Jun 2021 at 10:24, Yifeng Zhao <yifeng.z...@rock-chips.com> wrote: > > This patch adds support for the RK3568 platform to this driver. > > Signed-off-by: Yifeng Zhao <yifeng.z...@rock-chips.com>
I thought I had raised an objection to this patch previously, but did not see a discussion... So here we go again. In 2017, we decided to split the HDMI drivers such that there is a common core driver and a "mini-driver" wrapping it, so we don't pull in the extra code for every chip. See the original comment from Simon at https://patchwork.ozlabs.org/project/uboot/patch/1493394792-20743-4-git-send-email-philipp.toms...@theobroma-systems.com/#1648072 Given that we established that pattern already—and that there are practical benefits (e.g., in code-size), we should follow the same pattern for the SDHCI driver. Thank you, Philipp.
