Hello,
Please see inline.
On 7/26/21 9:40 AM, [email protected] wrote:
Message: 13
Date: Mon, 26 Jul 2021 07:34:06 -0600
From: Simon Glass<[email protected]>
To: U-Boot Mailing List<[email protected]>
Cc: Tom Rini<[email protected]>, Simon Glass<[email protected]>,
Albert Aribaud<[email protected]>, Andy Fleming
<[email protected]>, Joe Hershberger<[email protected]>, Marek
Vasut<[email protected]>, Mario Six<[email protected]>, Oleksandr
Zhadan and Michael Durrant<[email protected]>, Pavel
Herrmann<[email protected]>, Priyanka Jain
<[email protected]>, Rob Herring<[email protected]>, Stefan
Roese<[email protected]>, Stefano Babic<[email protected]>, Wolfgang Denk
<[email protected]>
Subject: [PATCH 00/33] pci: Drop all pre-driver model code
Message-ID:<[email protected]>
The hard work to actually enable DM_PCI everywhere was done recently. This
series attempts to drop most of the code that it no-longer needed now that
PCI has been converted to driver model.
It also drops the UCP1020 board since it has various unique build issues.
What issues are we talking about?Please name it.
Today's u-boot clone builds and runs fine in our module without any
warnings except:
> git clone https://source.denx.de/u-boot/u-boot.git u-boot-20210728
> cd u-boot-20210728
> make UCP1020_defconfig
> CROSS_COMPILE=powerpc-linux- make 2>222
> cat 222
===================== WARNING ======================
This board does not use CONFIG_DM. CONFIG_DM will be
compulsory starting with the v2020.01 release.
Failure to update may result in board removal.
See doc/driver-model/migration.rst for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_ETH (Driver Model
for Ethernet drivers). Please update the board to use
CONFIG_DM_ETH before the v2020.07 release. Failure to
update by the deadline may result in board removal.
See doc/driver-model/migration.rst for more info.
===================================================
It doesn't even support driver model so it seems reasonable to just remove
it.
1. Sure it's my fault that I didn't notice the warnings that CONFIG_DM
is the only choice to build and run u-boot.
2. Why is CONFIG_DM still present in `make menuconfig` options?
3. We only use u-boot as the first stage bootloader to start the kernel.
We need minimal device controllers support. We don't need anything like
PCI, USB, etc.
4. At least you need to add doc/driver-model/migration.rst to the source
tree from https://source.denx.de/u-boot/u-boot.git if you point to it in
your warnings.
And
5. I have seen NO reason to remove ANY support board without REAL
reasons to do so.
SUMMARY:
1. UCP1020_defconfig does not have any compiler warnings on build (at
least 2021.07.28 clone).
2. If now the only choice is CONFIG_DM, then it should be removed as an
option from "make menuconfig", and we will definitely fix the related
warnings/errors.
3. IMPO board support can be removed if it breaks when built and/or
breaks any other builds.
Thank you,
Oleks
The DM_PCI option disappears and only PCI is left.
--
Oleksandr Zhadan
[email protected]
416.621.0125 x.235
}|{/\|)/\|-|
