On Fri, Jul 02, 2021 at 12:36:18PM -0600, Simon Glass wrote: > This feature should never have been made available when driver model > or devicetree are disabled. Add these as conditions, so that we don't > create even more barriers to migration. > > Add a note about the substantial size increment associated with this > option. > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > Changes in v2: > - Split out new patch to make EFI_LOADER depend on DM and OF_CONTROL > - Note the approximate size of this feature in the help > > lib/efi_loader/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index 6242caceb7f..466abfed300 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -1,6 +1,6 @@ > config EFI_LOADER > bool "Support running UEFI applications" > - depends on OF_LIBFDT && ( \ > + depends on OF_LIBFDT && DM && OF_CONTROL && ( \ > ARM && (SYS_CPU = arm1136 || \ > SYS_CPU = arm1176 || \ > SYS_CPU = armv7 || \ > @@ -25,6 +25,8 @@ config EFI_LOADER > will expose the UEFI API to a loaded application, enabling it to > reuse U-Boot's device drivers. > > + For ARM 32-bit, this adds about 90KB to the size of U-Boot. > + > if EFI_LOADER > > config CMD_BOOTEFI_BOOTMGR
Note that we have platforms today with EFI_LOADER without OF_CONTROL, so this isn't strictly the right requirements. What do you think here Heinrich? -- Tom
signature.asc
Description: PGP signature
