Re: [PATCH] build: remove the variable NM in gen_ll_addressable_symbols.sh

[Patrick DELAUNAY]

On 7/20/21 8:50 PM, Simon Glass wrote:

Hi Patrick,

On Tue, 20 Jul 2021 at 12:34, Patrick Delaunay
<patrick.delau...@foss.st.com> wrote:

With LTO activated, the buildman tools failed with an error on my
configuration (Ubuntu 20.04, stm32mp15_trusted_defconfig) with the error:

../arm-linux-gnueabi/bin/nm:
         scripts/gen_ll_addressable_symbols.sh: file format not recognized

It seems the shell variable initialization NM=$(NM) is not correctly
interpreted when shell is started in the Makefile, but I have not this
issue when I compile the same target without buildman.

I don't found the root reason of the problem but I solve it by
providing $(NM) as script parameter instead using a shell variable.

The command executed is identical:

cmd_keep-syms-lto.c := NM=arm-none-linux-gnueabihf-gcc-nm \
u-boot/scripts/gen_ll_addressable_symbols.sh arch/arm/cpu/built-in.o \
.... net/built-in.o >keep-syms-lto.c

cmd_keep-syms-lto.c := u-boot/scripts/gen_ll_addressable_symbols.sh \
arm-none-linux-gnueabihf-gcc-nm arch/arm/cpu/built-in.o \
... net/built-in.o > keep-syms-lto.c

Serie-cc: Marek Behún <marek.be...@nic.cz>
Serie-cc: sjg

Series-cc

thanks, I RESEND the patch with updated commit message....

I made the same error (Serie vs Series)...

Again !

Best Regards

Patrick