On Fri, Jul 2, 2021 at 12:53 PM Marek Vasut <ma...@denx.de> wrote: > > On 7/2/21 9:43 PM, Tim Harvey wrote: > > On Fri, Jul 2, 2021 at 12:17 PM Marek Vasut <ma...@denx.de> wrote: > >> > >> On 7/2/21 2:15 AM, Tim Harvey wrote: > >>> There is no need to set and/or detect mode in of_to_plat > >> > >> Are you absolutely sure of that ? > >> > >> It used to be necessary to know the core mode early to determine which > >> driver (the gadget or host) to probe, that's why this code was in > >> of_to_plat. > >> > > > > Marek, > > > > I can't find a reason for the core mode to be known early and have > > tested it both with host and gadget mode on IMX6 and IMX8MM. Fabio has > > tested this change also (from another thread) with SPL SDP on IMX8MM > > (granted the SPL is not using DM_USB for that). > > > > It appears I accidentally forgot to cc the uboot list so I'll need to > > resend this at any rate. > > If I recall it correctly, the mode determination happened early because > it was necessary to find out which driver to probe (this one, or the > samsung gadget one) before it actually probed. I'm not sure myself if > this is still even applicable.
Marek, When I tested UMS with this series on imx6 based gwventana I had to troubleshoot a regression caused when I switched to DM_USB and found that the gadget driver isn't probed until you issue the ums command. I don't know if this helps reduce your hesitation here. I'm not sure what else you want me to do with this - personally I would like to see some more maintainers of boards using ehci-mx6 chime in (mx7?) with testing results showing host and device un-affected. I only have imx6q/imx6dl/imx8mm/imx8mn to test with here. Tim
