Hi Reinhard On Tue, Oct 26, 2010 at 5:04 PM, Reinhard Meyer <u-b...@emk-elektronik.de> wrote: > Dear Shawn Guo, >> On Tue, Oct 26, 2010 at 4:34 PM, Stefano Babic <sba...@denx.de> wrote: >>> On 10/26/2010 10:25 AM, Heiko Schocher wrote: >>>> We should set the CONFIG_SYS_INIT_SP_ADDR @ (IRAM_BASE_ADDR + >>>> IRAM_BASE_SIZE >>>> - CONFIG_SYS_GBL_DATA_SIZE) >>> Agree, this is what I set for the vision2 board. We should be consistent >>> and do the same for the mx51evk. >>> >>>> Don;t know if IRAM_BASE_SIZE exists ... >>> we must define it. I set it in the board configuration file, but it is >>> wrong. The value should be moved into register definition file for the >>> SoC (imx-regs.h) >>> >> I see many other platforms using 0x1000 offset way to define >> CONFIG_SYS_INIT_SP_ADDR, so I did that to make it a little bit more >> common. But I'm fine to start from the end, and will send v3 of this >> patch soon. > > I just tried to add the symbolic version > > #define CONFIG_SYS_INIT_SP_ADDR (xxx_SRAM_BASE + xxx_SRAM_SIZE - > CONFIG_SYS_GBL_DATA_SIZE) > > in AT91, but that means (assuming those xxx- defines come from an SoC > specific file) > that in start.s the includes > > #if defined(CONFIG_OMAP1610) > #include <./configs/omap1510.h> > #elif defined(CONFIG_OMAP730) > #include <./configs/omap730.h> > #endif > > have to be expanded for every SoC in question. Or to include the <soc>.h > into the <board>.h... > > Which way to go? > I'm going the way of including <soc>.h into <board>.h, as I see omap3_beagle.h is doing this way.
-- Regards, Shawn _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
