Hi Simon, > > t->bios_characteristics_ext1 = BIOS_CHARACTERISTICS_EXT1_ACPI; [...] > > #endif > > #ifdef CONFIG_EFI_LOADER > > Can you please drop this #ifdef while you are here - should use IS_ENABLED() >
I think Heinrich already merged those and sent a request to Tom. Regardless I'll send a follow up chaning this as well > > - t->bios_characteristics_ext1 |= BIOS_CHARACTERISTICS_EXT1_UEFI; > > + t->bios_characteristics_ext2 |= BIOS_CHARACTERISTICS_EXT2_UEFI; > > #endif > > - t->bios_characteristics_ext2 = BIOS_CHARACTERISTICS_EXT2_TARGET; > > + t->bios_characteristics_ext2 |= BIOS_CHARACTERISTICS_EXT2_TARGET; > > > > /* bios_major_release has only one byte, so drop century */ > > t->bios_major_release = U_BOOT_VERSION_NUM % 100; > > -- > > 2.32.0.rc0 > > > > Regards, > Simon Cheers /Ilias
