On Mon, 2010-10-25 at 20:10 +0530, Premi, Sanjeev wrote: > > -----Original Message----- > > From: Steve Sakoman [mailto:st...@sakoman.com] > > Sent: Monday, October 25, 2010 6:52 PM > > To: Premi, Sanjeev > > Cc: u-boot@lists.denx.de > > Subject: RE: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boards > > > > On Mon, 2010-10-25 at 15:28 +0530, Premi, Sanjeev wrote: > > > > -----Original Message----- > > > > From: u-boot-boun...@lists.denx.de > > > > [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Steve Sakoman > > > > Sent: Saturday, October 23, 2010 2:20 AM > > > > To: u-boot@lists.denx.de > > > > Subject: [U-Boot] [PATCH] ARMV7: Fix build for non-OMAP3 boards > > > > > > > > Commit c3d3a54 uses CONFIG_ARMV7 to determine whether to call the > > > > v7_flush_cache_all function. This breaks the build for > > all non-OMAP3 > > > > boards (like Panda and OMAP4430SDP) since there is only a > > > > v7_flush_cache_all > > > > implementation for OMAP3. > > > > > > > > This patch uses CONFIG_OMAP3XXX instead of CONFIG_ARMV7 so > > > > that only boards > > > > with a v7_flush_cache_all will make the call. > > > > > > [sp] Is this call board specific? > > > > No, it is not. > > [sp] I asked because I can see omap3/cache.S but not under omap-common/ > (as I was expecting) - neither in omap4/ > > Doesn't this patch works-around the problem by using CONFIG_OMAP34XX?
Yes, this is a hopefully temporary fix to allow non-OMAP3 ARMV7 boards to build. > Wouldn't change in cache.S (or Makefile) be better solution/ or > workaround. At least workaround will be visible to more eyes. Ideally we would have a generic ARMV7 implementation that would work for even non-OMAP ARMV7 processors. Someone who is familiar with the differences in ARMV7 cache implementations from the various silicon vendors would need to do this. This beyond my knowledge. A "second best" solution would be to have a cache.S that worked for both OMAP3 and OMAP4 in omap-common/ If this isn't possible, then we should add an OMAP4 specific cache.S in omap4/ But until we settle on the proper long term strategy this patch should be applied so that non-OMAP3 ARMV7 boards will build. Steve _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
