Re: [PATCH 2/4] Azure: Add fuse device for sandbox test.py tests

[Tom Rini]

On Fri, Jun 04, 2021 at 10:02:04PM +0300, Alper Nebi Yasak wrote:

> The EFI secure boot and capsule test setups need to prepare disk images
> for their tests using virt-make-fs, which requires access to the host
> fuse device. This is not exposed to the docker container by default and
> has to be added explicitly.
> 
> Since these tests are marked to run only on the sandbox board, add the
> fuse device only when testing on sandbox.
> 
> Signed-off-by: Alper Nebi Yasak <alpernebiya...@gmail.com>
> ---
> 
>  .azure-pipelines.yml | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
> index 35ab7f30b276..a4d796c41895 100644
> --- a/.azure-pipelines.yml
> +++ b/.azure-pipelines.yml
> @@ -318,7 +318,15 @@ jobs:
>            # as sandbox testing need create files like spi flash images, etc.
>            # (TODO: clean up this in the future)
>            chmod 777 .
> -          docker run -v $PWD:$(work_dir) $(ci_runner_image) /bin/bash 
> $(work_dir)/test.sh
> +          # Some EFI tests need extra docker args to run
> +          set --
> +          if [[ "${TEST_PY_BD}" == "sandbox" ]]; then
> +              # virt-make-fs needs the fuse device
> +              if modprobe fuse; then
> +                  set -- "$@" --device /dev/fuse:/dev/fuse
> +              fi
> +          fi
> +          docker run "$@" -v $PWD:$(work_dir) $(ci_runner_image) /bin/bash 
> $(work_dir)/test.sh

Thanks for addressing these issues.  For this specific patch, I think I
would prefer to just always pass in /dev/fuse with a comment about
needing it for some tests.

-- 
Tom

signature.asc
Description: PGP signature