On Wed,  2 Jun 2021 19:09:56 +0200
Marek Behún <marek.be...@nic.cz> wrote:

> +#define TURRIS_MOX_BOOTCMD_RESCUE \
> +     "setenv bootargs \"console=ttyMV0,115200 " \
> +                       "earlycon=ar3700_uart,0xd0012000\" && " \
> +     "sf probe && " \
> +     "sf read ${kernel_addr_r} 0x190000 && " \
> +     "lzmadec ${kernel_addr_r} ${ramdisk_addr_r} && " \
> +     "bootm ${ramdisk_addr_r}"

OMG, we should use constants for addresses here instead of
${kernel_addr_r} and ${ramdisk_addr_r}, in case user changes or removed
this variables.

I will update this in v2.

> +
>  #define CONFIG_EXTRA_ENV_SETTINGS    \
>       "scriptaddr=0x4d00000\0"        \
>       "pxefile_addr_r=0x4e00000\0"    \
>       "fdt_addr_r=0x4f00000\0"        \
>       "kernel_addr_r=0x5000000\0"     \
>       "ramdisk_addr_r=0x8000000\0"    \
> +     "bootcmd_rescue=" TURRIS_MOX_BOOTCMD_RESCUE "\0" \
>       BOOTENV
>  
>  #endif /* _CONFIG_TURRIS_MOX_H */

Reply via email to