Hi Ming
On Mon, 2021-05-31 at 09:06 +0200, liu.min...@gmail.com wrote:
> From: Ming Liu <liu.min...@gmail.com>
>
> Only one dtb is currently supported, so match with imx6-colibri.
Looks similar to commit 6f8ef051c5dd ("apalis_imx6: add
board_fit_config_name_match to support FIT in SPL") to
me.
I guess as we are currently not using that CONFIG_SPL_LOAD_FIT in our default
configuration(s) at all it won't
actually do anything. However, usually, it may be smarter to do so together
with also enabling it in the
default configuration as otherwise it will neither be compiled in nor really
tested at all. And could therefore
just as well not be done in the first place. But of course, then it would also
definitely be a "real" change
that bears risks...
Anyway, might be interesting to learn the real reason for doing it and if that
is deemed real useful to also
enable it by default. Thanks!
BTW: Do you always send your patches twice? I don't think that is required.
Cheers
Marcel
> Signed-off-by: Ming Liu <liu.min...@gmail.com>
> ---
> board/toradex/colibri_imx6/colibri_imx6.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/board/toradex/colibri_imx6/colibri_imx6.c
> b/board/toradex/colibri_imx6/colibri_imx6.c
> index c0e7754469..587d92a8e9 100644
> --- a/board/toradex/colibri_imx6/colibri_imx6.c
> +++ b/board/toradex/colibri_imx6/colibri_imx6.c
> @@ -1081,6 +1081,16 @@ void board_init_f(ulong dummy)
> board_init_r(NULL, 0);
> }
>
> +#ifdef CONFIG_SPL_LOAD_FIT
> +int board_fit_config_name_match(const char *name)
> +{
> + if (!strcmp(name, "imx6-colibri"))
> + return 0;
> +
> + return -1;
> +}
> +#endif
> +
> void reset_cpu(void)
> {
> }
