Hi, On Wed, 12 May 2021 at 08:55, Etienne Carriere <etienne.carri...@linaro.org> wrote: > > From: Patrick Delaunay <patrick.delau...@st.com> > > This patch implements SCMI APIs to retrieve the number and the name of > SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages. > > Signed-off-by: Gabriel Fernandez <gabriel.fernan...@st.com> > Signed-off-by: Patrick Delaunay <patrick.delau...@st.com> > Signed-off-by: Etienne Carriere <etienne.carri...@linaro.org> > --- > drivers/clk/clk_scmi.c | 101 +++++++++++++++++++++++++++++++++++++++ > include/scmi_protocols.h | 43 +++++++++++++++++ > 2 files changed, 144 insertions(+)
Reviewed-by: Simon Glass <s...@chromium.org> I notice that this code uses pointers to return error codes. We tend to avoid that in U-Boot and use an integer return instead, with the pointer returned as a parameter. We have things like log_msg_ret() to help with that. I don't have strong feelings about this if the goal is to make the code match linux code. But if this code is for U-Boot only, please do avoid it. Regards, Simon
