Hi Patrick, On Tue, Mar 16, 2021 at 7:16 PM Patrick DELAUNAY <patrick.delau...@foss.st.com> wrote: > > Hi Jagan, > > On 3/15/21 6:32 PM, Jagan Teki wrote: > > Engicam MicroGEA STM32MP1 Micro SOM has mounted 1x4Gb DDR3 > > which has 16bits width 533Mhz frequency. > > > > Add DDR configurations via dtsi. > > > > Reviewed-by: Patrice Chotard <patrice.chot...@foss.st.com> > > Signed-off-by: Jagan Teki <ja...@amarulasolutions.com> > > --- > > Changes for v2: > > - collect Patrice r-b > > > > ...m32mp15-ddr3-microgea-1x4Gb-1066-binG.dtsi | 121 ++++++++++++++++++ > > 1 file changed, 121 insertions(+) > > create mode 100644 > > arch/arm/dts/stm32mp15-ddr3-microgea-1x4Gb-1066-binG.dtsi > > > > diff --git a/arch/arm/dts/stm32mp15-ddr3-microgea-1x4Gb-1066-binG.dtsi > > b/arch/arm/dts/stm32mp15-ddr3-microgea-1x4Gb-1066-binG.dtsi > > new file mode 100644 > > index 0000000000..950f292abb > > --- /dev/null > > +++ b/arch/arm/dts/stm32mp15-ddr3-microgea-1x4Gb-1066-binG.dtsi > > @@ -0,0 +1,121 @@ > > +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause > > +/* > > + * Copyright (C) 2018, STMicroelectronics - All Rights Reserved > > + * > > + * STM32MP157C DK1/DK2 BOARD configuration > > + * 1x DDR3L 4Gb, 16-bit, 533MHz. > > + * Reference used NT5CC256M16DP-DI from NANYA > > + * > > + * DDR type / Platform DDR3/3L > > + * freq 533MHz > > + * width 16 > > + * datasheet 0 = MT41J256M16-187 / DDR3-1066 bin G > > + * DDR density 4 > > + * timing mode optimized > > + * Scheduling/QoS options : type = 2 > > + * address mapping : RBC > > + * Tc > + 85C : N > > + */ > > This file is identical to stm32mp15-ddr3-1x4Gb-1066-binG.dtsi, because > it is a files generated > > with CubeMX with the same parameters. > > Do you any reason to duplicate it ? > > Do you expect some board-specific tuning or configuration with be > integrated latter.
Yes, ie reason. You are right, I think will reuse exiting dtsi and update based on future requirements. I Will update in the next version, thanks! -- Jagan Teki, Amarula Solutions India Pvt. Ltd. Co-Founder & Embedded Linux Architect 405/E-Block, Sri Lakshmi Shubham Arcade, Chandanagar, Hyderabad - 500050, India M. (+91) 910 009 0959 [`as] http://www.amarulasolutions.com
