On Fri, Mar 12, 2021 at 09:35:42PM +0800, Bin Meng wrote: > +- The old DT binding, where 'fixed-link' is a property with 5 cells > + encoding various information about the fixed PHY, in the form of > + <phy_id, full-duplex, speed, pause, asym-pause>. > + > + * 'phy_id', emulated PHY ID, choose any but unique to the all specified > + fixed-links
Could you please explicitly state that U-Boot deliberately ignores the phy_id and unconditionally uses PHY_FIXED_ID? It would be suicidal to do anything else (and I see Linux ignores fixed_link_prop[0] too), but at least we should be upfront about it. > + * 'full-duplex', 0 for half duplex or 1 for full duplex > + * 'speed', link speed in Mbits/sec, accepts only 10, 100 and 1000 > + * 'pause', 0 for no pause, 1 for pause > + * 'asym-pause', 0 for no asymmetric pause, 1 for asymmetric pause Reviewed-by: Vladimir Oltean <vladimir.olt...@nxp.com>
