Hi Bin, Simon, On 21/03/05 10:03:p, Bin Meng wrote: > On Fri, Mar 5, 2021 at 10:31 PM Simon Glass <s...@chromium.org> wrote: > > If I previously reviewed it you can add my tag.
I wasn't sure of the correct etiquette when a large rearrangement of the patches had been done; I'll keep this in mind. > > I think sandbox driver/tests being separate is a good idea. > > Yes, as Simon said, sandbox driver/test should be a separate patch. This will be sent along shortly. The initial rework commit email is still fairly sizeable (+490 -272), but I've compared this series with v4 (which had sjg's Reviewed-by: on all initially) and confirmed nothing new has crept in other than: * part 1: * adding config QFW_PIO to select the PIO driver * completing documentation to Sphinx standard * part 2: * nothing new * part 3: * adding config QFW_MMIO to select the driver * part 4: * just adds two `select's to Kconfig So there should be only these parts of the patch needing careful review. Given parts 1, 3 and 4 are still at least partly unreviewed, I will not carry the Reviewed-by: over. 2 is good to go. Best, Asherah
